Remove unsafe options #10360
Closed
Remove unsafe options #10360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For quite some time now, our networking layer makes sure to create safe messages as in not using the shared buffers. This is great, and we should remove the old support for "unsafe" notion in our codebase. closes elastic#10360
kimchy
force-pushed
the
remove_content_unsafe
branch
from
a5ec8e8
to
e31688d
Compare
|
LGTM |
|
LGTM |
|
this made my day +1 |
|
btw. not sure if we need to do this on |
|
@s1monw looking at it now for 1.6, so far looks like almost a clean merge, will update |
kimchy
added a commit
that referenced
this pull request
Apr 1, 2015
For quite some time now, our networking layer makes sure to create safe messages as in not using the shared buffers. This is great, and we should remove the old support for "unsafe" notion in our codebase. closes #10360
dadoonet
added a commit
to elastic/elasticsearch-river-rabbitmq
that referenced
this pull request
Apr 25, 2015
Due to elastic/elasticsearch#10360 Need to be backported in master (2.0.0) and in es-1.x (1.6.0) Closes #98.
dadoonet
added a commit
to elastic/elasticsearch-river-rabbitmq
that referenced
this pull request
Apr 25, 2015
Due to elastic/elasticsearch#10360 Need to be backported in master (2.0.0) and in es-1.x (1.6.0) Closes #98. (cherry picked from commit de31ef8)
clintongormley
added
the
:Distributed/Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For quite some time now, our networking layer makes sure to create safe messages as in not using the shared buffers. This is great, and we should remove the old support for "unsafe" notion in our codebase.
Note, this will break java code that provided the unsafe flag, it needs to be removed.