Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reuse source index UUID on restore #10367

Merged
merged 0 commits into from Apr 1, 2015

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Apr 1, 2015

Today we reuse the UUID of the source index on restore. This can create conflicts
with existing shard state on disk. This also causes multiple indices with the same
UUID. This commit preserves the UUID of an existing index or creates a new UUID for
a newly created index.

@s1monw s1monw added >bug v2.0.0-beta1 :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v1.6.0 v1.5.1 labels Apr 1, 2015
@s1monw
Copy link
Contributor Author

s1monw commented Apr 1, 2015

@imotov can you please review this?

@imotov
Copy link
Contributor

imotov commented Apr 1, 2015

LGTM

@s1monw s1monw closed this Apr 1, 2015
@s1monw s1monw merged commit dc38df2 into elastic:master Apr 1, 2015
@s1monw s1monw deleted the uuid_reuse_on_restore branch April 2, 2015 08:16
@clintongormley clintongormley changed the title [RESTORE] Don't reuse source index UUID on restore Don't reuse source index UUID on restore May 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v1.5.1 v1.6.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants