Remove deprecated methods from ScriptService #10476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the following methods from `ScriptService`, which don't require the `ScriptContext` argument: ``` public CompiledScript compile(String lang, String script, ScriptType scriptType) public ExecutableScript executable(String lang, String script, ScriptType scriptType, Map<String, Object> vars) public SearchScript search(SearchLookup lookup, String lang, String script, ScriptType scriptType, @nullable Map<String, Object> vars) ``` Also removed the ScriptContext.Standard.GENERIC_PLUGIN enum value, as it was used only for backwards compatibility. Plugins that make use of scripts should declare their own script contexts through `ScriptModule#registerScriptContext` and use them when compiling/executing scripts.
javanna
added
>enhancement
>breaking
v2.0.0-beta1
review
:Core/Infra/Scripting
|
@uboness can you have a look please? |
|
LGTM |
|
Note: this change is breaking only for plugins that make use of scripts. |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the following methods from
ScriptService, which don't require theScriptContextargument:Also removed the
ScriptContext.Standard.GENERIC_PLUGINenum value, as it was used only for backwards compatibility.Plugins that make use of scripts should declare their own script contexts through
ScriptModule#registerScriptContextand use them when compiling/executing scripts.