Add INFO logging saying whether each path.data is on an SSD #10502
Conversation
|
this is going to log it quite a bit for shards allocated and such, maybe we should do it on NodeEnvironment, @s1monw thoughts? |
|
yeah lets put it on NodeEnvironmetn for now? |
|
OK I'll move to NodeEnvironment... |
|
OK I moved it to NodeEnvironment. Note that this is not as "accurate" since before we checked the actual Directory instance that Lucene would be using, so if someone is creating some per-index symlink or something then we could log the wrong thing here ... but I agree it is less noisy. |
|
LGTM |
mikemccand
changed the title
… Files.getFileStore(Path)
|
OK I merged this with the existing (TRACE) logging we were already doing for free space, but upgraded to INFO logging, and added total space, spins, FileStore, FileStore.type() to the output. So now e.g. on my box I see a line like this: |
|
+1 |
|
looks great. we should try to get them to fix that FileStore bug one day! |
This change logs total space, free space, usable free space, an estimate of whether the IO system spins (e.g., SSD or not), the mount point and filesystem type, on node startup. It produces log output like this: [2015-04-09 12:09:30,244][INFO ][env ] [node_t0] node data locations details: -> /l/es.logspins/target/J0/data/TEST-haswell-CHILD_VM=[0]-CLUSTER_SEED=[2926863498862121027]-HASH=[AFC194B1B384B]/nodes/0, free_space [260.6gb], usable_space [256.3gb], total_space [465gb], spins? [no], mount [/ (/dev/mapper/haswell--vg-root)], type [btrfs] Closes #10502
|
On 1.x backport I had to drop the "spins: " part because that's only in Lucene 5.x. |
clintongormley
added
:Core/Infra/Logging
Recently in Lucene we added an IOUtils.spins() method, which returns true for old-fashioned spinning magnets hard drives, and false for SSDs or RAM disks.
It's best effort, but should work well on Linux.
I think we should log this? It can be helpful when looking at a node's log to see whether it's using SSDs for not for it shards...