Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEO] Modify GeoShapeFieldMapper to accept precision field updates #10514

Closed
nknize opened this issue Apr 9, 2015 · 3 comments
Closed

[GEO] Modify GeoShapeFieldMapper to accept precision field updates #10514

nknize opened this issue Apr 9, 2015 · 3 comments
Assignees
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement

Comments

@nknize
Copy link
Contributor

nknize commented Apr 9, 2015

Related to #10513 There are a couple enhancement discussion points here:

  • GeoPointFieldMapper disallows any changes. This makes sense since changing any one of the parameters compromises the integrity of all existing commits. Thus new commits require a full reindex.
  • We should be able to allow the changing of precision on GeoShapeFieldMapper since each existing term is identified in the PrefixTree as either an internal or leaf node. If we increase the precision, existing terms will terminate at the level of the leaves, so they will remain at the same precision when they were created. The converse is true, decreasing precision will reduce the resolution of newly created shapes and the leaf nodes will prevent traversal beyond the shapes tree depth. This will be a separate enhancement issue beyond the scope of fixing this bug.
@nknize nknize added >enhancement discuss :Analytics/Geo Indexing, search aggregations of geo points and shapes labels Apr 9, 2015
@clintongormley
Copy link

@nknize is this still relevant?

@nknize
Copy link
Contributor Author

nknize commented Jan 20, 2016

This is still relevant for geo_shape - for now. I'll be revisiting shortly.

Use case: a mapping is created with highest level of precision (without knowing an optimal precision a priori). Suddenly geo_shape queries and inserts become sluggish. This allows precision changes without requiring a full reindex.

@imotov imotov self-assigned this Jun 13, 2018
@nknize
Copy link
Contributor Author

nknize commented Feb 28, 2020

Now that we have BKD based GeoShapes we are no longer supporting PrefixTrees

@nknize nknize closed this as completed Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement
Projects
None yet
Development

No branches or pull requests

4 participants