Log sending translog operation batches to nodes #10544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakrone
added
v2.0.0-beta1
review
:Core/Infra/Logging
Closed
|
LGTM, it's trace so I don't think we need to worry about volume. Why not push it to 1.6 as well? |
|
should we also log the leftover that is sent at the end? |
Yep, I will add this and push since Boaz gave the LGTM (unless someone objects) |
dakrone
force-pushed
the
log-sending-translog-ops
branch
from
12dc280
to
abb1677
Compare
dakrone
force-pushed
the
log-sending-translog-ops
branch
from
abb1677
to
fcbe3f9
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is too verbose, because it will log every 1000 translog operations or 512kb.
Thoughts?