Remove useless random translog directory selection #10589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -237,7 +236,7 @@ public void newTranslog(long id) throws TranslogException, IOException { | |||
| if (currentFree < size) { | |||
| size = currentFree; | |||
| location = file; | |||
| } else if (currentFree == size && ThreadLocalRandom.current().nextBoolean()) { | |||
| } else if (currentFree == size) { | |||
There was a problem hiding this comment.
Do we need the else condition at all now? Could we just keep the first if block (meaning we take the first location instead of the last if they are all equal?)
|
LGTM, just left one small question. |
|
good point @rjernst I removed it |
s1monw
force-pushed
the
more_deterministic
branch
from
a6adb25
to
3b6ef0f
Compare
Using ThreadLocalRandom only prevents reproducibilty but doesn't buy us anything. In production different datapaths won't have the same since anyway or at least with a low likelyhood.
s1monw
force-pushed
the
more_deterministic
branch
from
3b6ef0f
to
210f6c7
Compare
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ThreadLocalRandom only prevents reproducibilty but doesn't buy us
anything. In production different datapaths won't have the same since
anyway or at least with a low likelyhood.