Make GeoContext mapping idempotent #10602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areek
added
>bug
v2.0.0-beta1
review
:Search/Suggesters
areek
force-pushed
the
fix/context_mapping_idmptcy
branch
from
49decd8
to
98899c5
Compare
areek
added
the
:Search/Mapping
| .endObject().endObject() | ||
| .endObject().endObject(); | ||
|
|
||
| assertAcked(prepareCreate(INDEX).setSettings(ImmutableSettings.builder().put(IndexMetaData.SETTING_NUMBER_OF_SHARDS, 1)).addMapping(TYPE, mapping.string())); |
There was a problem hiding this comment.
Why does this need a single shard?
There was a problem hiding this comment.
The bug could be reproduced using a single shard, changed it to test with multiple shards
|
@areek The fix LGTM, just a couple questions about the test. |
areek
force-pushed
the
fix/context_mapping_idmptcy
branch
from
3164b03
to
b072cac
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10581
closes #8937