Single value numeric queries shouldn't be handled by NumericRangeQuery

[markharwood]

For performance reasons this change uses a TermQuery wrapped in a ConstantScoreQuery instead of a NumericRangeQuery with start and end values the same.

Closes #10646

[rjernst]

LGTM

[markharwood]

Working on a change to address termFilter too...

[markharwood]

@rmuir Can I get a review of this now that I've added termFilter support?
Thx

[rmuir]

This change looks great to me. Its very important for master where otherwise we'd always read all the postings for the term into a bitset in memory, which is bad if we are e.g. AND'ing with a bunch of other clauses. Even for older branches, we would sometimes do this if the term has a high docfreq (which is exactly when you do not want to do this). So it is best to explicitly make term query/filters instead. I also like the internal cleanup, +1.

[markharwood]

Thanks @rmuir - which branches would you like to see have this?

[rmuir]

I think we should do 2.0 and 1.6 personally. Its not technically a bug, so I would omit from 1.5.2 just to be on the safe side.

[markharwood]

OK - I'll push to 1.x and master if there are no objections

[jpountz]

+1 on master and 1.x

[s1monw]

I think we should do 2.0 and 1.6 personally. Its not technically a bug, so I would omit from 1.5.2 just to be on the safe side.

+1

[markharwood]

Pushed to 1.x in f9e044d and master in 05c3d05