Simplify dynamic mappings updates. #10720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // hand putting the mapping would start the river, which expects | ||
| // to find a _meta document | ||
| // So we have no choice but to index first and send mappings afterwards | ||
| indexService.mapperService().merge(indexRequest.type(), new CompressedString(update.toBytes()), true); |
There was a problem hiding this comment.
can we assigne indexService.mapperService() to a var? just to remove the chaining :)
|
left a couple of comments |
|
LGTM I think we should add the UUID in a second step in a followup issue |
While dynamic mappings updates are using the same code path as updates from the API when applied on a data node since elastic#10593, they were still using a different code path on the master node. This commit makes dynamic updates processed the same way as updates from the API, which also seems to do a better way at acknowledgements (I could not reproduce the ConcurrentDynamicTemplateTests failure anymore). It also adds more checks, like for instance that indexing on replicas should not trigger dynamic mapping updates since they should have been handled on the primary before. Close elastic#10720
jpountz
force-pushed
the
fix/simplify_mapperupdatedaction
branch
from
9301b56
to
c6cdf77
Compare
jpountz
added a commit
that referenced
this pull request
Apr 23, 2015
Mappings: simplify dynamic mappings updates. Close #10720
clintongormley
changed the title
clintongormley
added
the
:Search/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While dynamic mappings updates are using the same code path as updates from the
API when applied on a data node since #10593, they were still using a different
code path on the master node. This commit makes dynamic updates processed the
same way as updates from the API, which also seems to do a better way at
acknowledgements (I could not reproduce the ConcurrentDynamicTemplateTests
failure anymore). It also adds more checks, like for instance that indexing on
replicas should not trigger dynamic mapping updates since they should have been
handled on the primary before.