Use of default CONF_DIR/CONF_FILE in plugin install #10721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
v2.0.0-beta1
review
:Core/Infra/Plugins
|
Removing review label for now, something breaks with the security manager. |
tlrx
force-pushed
the
plugin-install-use-conf-dir
branch
from
485666c
to
3a0faff
Compare
|
@spinscale Could you please have a look at this one? It should be straightforward to test. Thanks |
|
tested plugin installation (marvel and kopf) and removal with deb on debian jessie ubuntu trusty (initd), ubuntu vivid (systemd), with RPM on opensuse ... all worked flawless Minor nitpick: Maybe put a "Packaging: " prefix in the commit message/PR title, so its easier for others what this is about Last part: I'd love to get the BATS stuff into CI after this. LGTM! |
tlrx
changed the title
The bin/plugin script now uses the default CONF_DIR & CONF_FILE environment vars. This allows to install a plugin even if Elasticsearch has been installed with a RPM or a DEB package. This commit also adds testing files for TAR archive and plugins installation. Closes elastic#10673
tlrx
force-pushed
the
plugin-install-use-conf-dir
branch
from
3a0faff
to
862cec5
Compare
|
@spinscale thanks a lot for your review! I updated the commit/pr message. |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bin/plugin script now uses the default CONF_DIR & CONF_FILE environment vars. This allows to install a plugin even if Elasticsearch has been installed with a RPM or a DEB package. This commit also adds testing files for TAR archive and plugins installation. Related to ##7946.
Closes #10673