Refactor SSD/FileStore logic out of NodeEnvironment #10755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I like tying the spins attribute into the filestore itself! |
|
LGTM |
rmuir
added a commit
that referenced
this pull request
Apr 23, 2015
refactor SSD/FileStore logic out of NodeEnvironment
clintongormley
added
>enhancement
:Core/Infra/Core
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic is rather hairy and nicer to be in its own place. It currently has to do things like "match" the result of Files.getFileStore with the "better" data found in FileSystem.getFileStores(), detect SSDs to set "spins", etc.
We can encapsulate a lot of the logic by just providing an "enhanced" filestore that takes care of the pain points. For example, exposes "spins" as an optional attribute so calling code doesn't have to worry about all the hairiness here.
Finally the current logic being in NodeEnvironment causes security challenges/complexity on #10717:
On the other hand, with this patch, asking for Files.getFileStore("/usr/foo") only requires read permission to "/usr/foo" itself, and "getFileStoreAttributes".