Term positions in analyze API should start at 1, not 0 #10771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johtani
added
>bug
v2.0.0-beta1
review
:Search/Analysis
|
LGTM |
|
@johtani Let's make this change only master - it's a breaking change. |
|
@clintongormley I see. |
| int increment = posIncr.getPositionIncrement(); | ||
| if (increment > 0) { | ||
| position = position + increment; | ||
| } | ||
| tokens.add(new AnalyzeResponse.AnalyzeToken(term.toString(), position, offset.startOffset(), offset.endOffset(), type.type())); |
There was a problem hiding this comment.
This doesn't look correct to me: of course would be analyzer as a single token course at position 0 while it should be at position 1.
I think the right fix is to put back tokens.add where it was before and instead to initialize position at -1.
There was a problem hiding this comment.
Good catch, thanks!
|
@jpountz Fix your comment and add the test . |
|
LGTM. Thanks @johtani ! |
johtani
force-pushed
the
fix/wrong_position_returned_analyze_api
branch
2 times, most recently
from
f8efba7
to
ca3d941
Compare
johtani
force-pushed
the
fix/wrong_position_returned_analyze_api
branch
from
ca3d941
to
933edf7
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, Analyze API return 1 as 1st token.
Analyze API should return 0 as 1st token, looks like TermVector.