Sampler agg could not be used with Terms agg’s order. #10785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpountz + @colings86 suggested reviewers if you have the time please :) |
| @@ -189,7 +263,7 @@ public void replayRelatedMatches(ScoreDoc[] sd) throws IOException { | |||
| if ((rebased >= 0) && (rebased <= maxDocId)) { | |||
| currentScore = scoreDoc.score; | |||
| currentDocId = rebased; | |||
| leafCollector.collect(rebased, 0); | |||
| leafCollector.collect(rebased, scoreDoc.shardIndex); | |||
There was a problem hiding this comment.
Could we add a comment here reminding that the shardIndex is being used to store the parent bucket ordinal?
|
@markharwood left a couple of small comments |
|
Rebased on latest master |
| private int shardSize; | ||
| private PerSegmentCollects perSegCollector; | ||
| private int matchedDocs; | ||
| private BigArrays bigArrays; |
|
Left some minor comments, otherwise it looks good to me |
|
@jpountz changed to always return 0 for docCount if no prior collections rather than erroring. |
|
This is what I meant indeed! LGTM |
|
Pushed to master in 8c3500a |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sampler agg was not capable of collecting samples for more than one parent bucket.
Added a Junit test case and changed BestDocsDeferringCollector to internally maintain collections per parent bucket.
Closes #10719