Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Preconditions class #10873

Merged
merged 1 commit into from Apr 29, 2015
Merged

Conversation

kimchy
Copy link
Member

@kimchy kimchy commented Apr 29, 2015

We don't need our own anymore, since we removed the Elasticsearch illegal argument exception

We don't need our own anymore, since we removed the Elasticsearch illegal argument exception
@javanna
Copy link
Member

javanna commented Apr 29, 2015

LGTM

@s1monw
Copy link
Contributor

s1monw commented Apr 29, 2015

can we use Objects.requireNonNull(T obj, String message) instead?

@kimchy
Copy link
Member Author

kimchy commented Apr 29, 2015

@s1monw I first wanted to remove the Preconditions class first that we don't need anymore

@s1monw
Copy link
Contributor

s1monw commented Apr 29, 2015

ok not sure if it's worth 2 PRs ?

@kimchy
Copy link
Member Author

kimchy commented Apr 29, 2015

its a bigger change, since there are other places that use guava preconditions checkNonNull, also, we can't replace most of the ones here, which are for illegal argument

@s1monw
Copy link
Contributor

s1monw commented Apr 29, 2015

ok fair enough!

kimchy added a commit that referenced this pull request Apr 29, 2015
@kimchy kimchy merged commit c55818f into elastic:master Apr 29, 2015
@kevinkluge kevinkluge removed the review label Apr 29, 2015
@kimchy kimchy deleted the remove_preconditions branch April 29, 2015 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants