Read configuration file with .yaml suffix #10909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug whereby we failed to read an elasticsearch config file with the .yaml extension. This commit allows elasticsearch config files to be suffixed with: .yml, .yaml, .json, .properties. Closes #9706
|
Change looks good but I think we should have a test for it too. Also, I remember making the same change on |
|
One more thing, this can go into 1.x too right? |
|
I considered abstracting out the code from |
|
Yes, it can go into 1.x. |
fair enough, can we have a test for this change though? |
|
@javanna Added a test |
|
LGTM thanks @aleph-zero |
|
Added 1.6.0 and 1.5.3 labels, should be easy to backport ;) |
brwe
added a commit
that referenced
this pull request
May 28, 2015
Read configuration file with .yaml suffix
aleph-zero
pushed a commit
that referenced
this pull request
May 28, 2015
Read configuration file with .yaml suffix
aleph-zero
pushed a commit
that referenced
this pull request
May 28, 2015
Read configuration file with .yaml suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug whereby we failed to read an elasticsearch config file with
the .yaml extension. This commit allows elasticsearch config files to
be suffixed with: .yml, .yaml, .json, .properties.
Closes #9706