Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify securitymanager init #10936

Merged
merged 13 commits into from May 4, 2015
Merged

Simplify securitymanager init #10936

merged 13 commits into from May 4, 2015

Conversation

rmuir
Copy link
Contributor

@rmuir rmuir commented May 2, 2015

Today we create a temp file, concatenate our template with some dynamically generated rules, and then set a sysprop to the new temp file.

A custom java.security.Policy is cleaner and easier to understand: we can avoid the sysprop, temp files, path escaping, etc.

@kimchy
Copy link
Member

kimchy commented May 3, 2015

nice, much cleaner! I think that on a different change we should see how we can separate the test rules from the security.policy, since it will allow us to get read of create security manager permission?

LGTM

@rmuir
Copy link
Contributor Author

rmuir commented May 3, 2015

The whole idea is that the system can only do what its tested to do. If we want to do a bunch of untested shit, thats cool, but id rather stay out in that case.
So for better security, clean up the tests. No cheating.

@kimchy
Copy link
Member

kimchy commented May 3, 2015

I see, I thought it was needed in the tests only test the security manager feature itself...

@rmuir
Copy link
Contributor Author

rmuir commented May 3, 2015

I dont think creating an sm is particularly harmful. as opposed to setting it. But there is some reason tests need it. Like many of the many permissions here that need to be cleaned up

rmuir added a commit that referenced this pull request May 4, 2015
@rmuir rmuir merged commit f042b8f into elastic:master May 4, 2015
@clintongormley clintongormley changed the title simplify securitymanager init Simplify securitymanager init Jun 8, 2015
@clintongormley clintongormley added >enhancement :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts labels Jun 8, 2015
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >enhancement Team:Delivery Meta label for Delivery team v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants