New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify securitymanager init #10936
Conversation
nice, much cleaner! I think that on a different change we should see how we can separate the test rules from the security.policy, since it will allow us to get read of create security manager permission? LGTM |
The whole idea is that the system can only do what its tested to do. If we want to do a bunch of untested shit, thats cool, but id rather stay out in that case. |
I see, I thought it was needed in the tests only test the security manager feature itself... |
I dont think creating an sm is particularly harmful. as opposed to setting it. But there is some reason tests need it. Like many of the many permissions here that need to be cleaned up |
Today we create a temp file, concatenate our template with some dynamically generated rules, and then set a sysprop to the new temp file.
A custom java.security.Policy is cleaner and easier to understand: we can avoid the sysprop, temp files, path escaping, etc.