Wait for mappings to be available on the primary before indexing. #10949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
review
v2.0.0-beta1
:Search/Mapping
| @@ -152,7 +165,8 @@ protected TransportRequestOptions transportOptions() { | |||
| } | |||
|
|
|||
| protected boolean retryPrimaryException(Throwable e) { | |||
| return TransportActions.isShardNotAvailableException(e); | |||
| return e.getClass() == RetryOnPrimaryException.class | |||
There was a problem hiding this comment.
should we subclass IllegalIndexShardStateException instead of IndexShardException then we don't need to change retryPrimaryException
There was a problem hiding this comment.
Actually IllegalIndexShardStateException seems to be about shards not being in the right shard state (STARTED, RECOVERING, ...) which does not seem to apply here
|
left 2 comments LGTM in general |
|
@s1monw I initially liked the idea of reusing IllegalIndexShardStateException but this one is more about shards being eg. not started yet, while in this case the shard is started and working, it just happens to not have the latest version of the cluster state. |
…exing. In some cases it might happen that a mapping which is already available on the master node is not available yet on the node that holds the primary shard. This commit changes indexing on the primary shard so that if a dynamic update is triggered then the index operation is re-tried until required mappings are available locally (using cluster state observing).
jpountz
force-pushed
the
fix/wait_for_mappings_on_primary
branch
from
9917ef6
to
8a19bf3
Compare
jpountz
added a commit
that referenced
this pull request
May 6, 2015
Mappings: Wait for mappings to be available on the primary before indexing.
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it might happen that a mapping which is already available on the
master node is not available yet on the node that holds the primary shard.
This commit changes indexing on the primary shard so that if a dynamic update
is triggered then the index operation is re-tried until required mappings are
available locally (using cluster state observing).