Remove exitVM permissions #10963
Merged
Remove exitVM permissions #10963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| keepAliveLatch.countDown(); | ||
| private void stop() { | ||
| try { | ||
| if (node != null) { |
There was a problem hiding this comment.
can we just use IOUtils.close here?
There was a problem hiding this comment.
I didn't make bootstrap Closeable because i didnt want close to be a public method. The class must be public so its main method can be run, but otherwise a lot of this stuff is still crazy. like even the static INSTANCE would be great to eliminate.
We could factor out the java code to be different... I can do it here if we really need but I would love to defer that.
There was a problem hiding this comment.
I mean to close node and safe the conditional... but it's Releasable so you can use Releasables.close()
|
left one minor comment... LGTM otherwise |
clintongormley
added
>enhancement
:Delivery/Packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tricky part here is just the windows handler for closing the console.
But its not so bad if we just have that handler properly shut down the instance instead of doing System.exit.
There is also some general refactoring to Bootstrap. I'm sorry to mix this in, but it was too hard to reason about otherwise for me :)
Tested on linux, mac, and windows. also tested closing windows console worked.