Rename Moving Average models to their "common" names #10964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,7 @@ A `moving_avg` aggregation looks like this in isolation: | |||
| { | |||
| "movavg": { | |||
|
Other than the typo @rjernst pointed out it LGTM |
Previously, we were using the "statistical", technically accurate name. Instead, we should probably use the name that people are familiar with, e.g. "Holt Winters" instead of "triple exponential". To that end: - `single_exp` becomes `ewma` (exponentially weighted moving average) - `double_exp` becomes `holt` When the `triple_exp` is added, it will be called `holt_winters`.
polyfractal
force-pushed
the
feature/aggs_movavg_rename
branch
from
5fe74b0
to
3eb9cb9
Compare
polyfractal
added a commit
that referenced
this pull request
May 6, 2015
Rename Moving Average models to their "common" names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using the "statistical", technically accurate name. Instead, we should probably use the name that people are familiar with, e.g. "Holt Winters" instead of "triple exponential". To that end:
single_expbecomesewma(exponentially weighted moving average)double_expbecomesholtWhen the
triple_expis added, it will be calledholt_winters.