Let HTTPS work correctly #10983
Merged
Let HTTPS work correctly #10983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but lets get another review before merging |
|
+1 |
|
Do I count? +1 maybe a parameter that disables it like |
|
@nik9000 if you want to break https in the jvm, you can configure this in the jvm configuration. I think for any esoteric cases that need it, we should just recommend that and not have options to do it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently pluginmanager init disables https verification jvm-wide for any HttpsURLConnections. This is seriously screwed-up, and makes https completely useless here. It does this without any comment or justification as to why.
If you don't want the cert check, just use http. or configure this trust stuff in your jvm differently. But we should let HTTPS just work correctly by default.
cc: @jaymode