Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libsigar #11034

Closed
rmuir opened this issue May 7, 2015 · 6 comments
Closed

Remove libsigar #11034

rmuir opened this issue May 7, 2015 · 6 comments

Comments

@rmuir
Copy link
Contributor

rmuir commented May 7, 2015

Supposedly ES works if its not available, hence, its unnecessary.

Having uunecessary JNI dependencies is too much.

@s1monw
Copy link
Contributor

s1monw commented May 7, 2015

+1 in general

@dakrone
Copy link
Member

dakrone commented May 7, 2015

+1

@kimchy
Copy link
Member

kimchy commented May 7, 2015

the fact that it works without mainly comes for the cases where there isn't an OS sigar supports, or its running embedded and someone doesn't wish to distribute sigar.

My main concern with sigar is that the project has stagnated. There hasn't been a new release since 1.6.4 which happened a few years ago... .

It has been very handy to use. Single API call to get the status on 100 node cluster. Many monitoring tools (bigdesk, ElasticHQ, ...) for ES rely on it (since its part of the API), and the ones I have found handy are basic ones, just with an opportunity to see the state across the cluster easily. I've mainly used cpu (os and process), swap usage, and in extreme cases network and fs statistics.

@lukas-vlcek
Copy link
Contributor

Do I understand this correctly that you are considering dropping REST APIs (cluster, admin...) that expose info based on Sigar lib? This would be unfortunate IMO. Not because I am Bigdesk maintainer but because getting this info directly from ES is extremely valuable feature. It is one of the reasons why we are using ES in our team.

@s1monw
Copy link
Contributor

s1monw commented Jun 1, 2015

Do I understand this correctly that you are considering dropping REST APIs (cluster, admin...) that expose info based on Sigar lib? This would be unfortunate IMO. Not because I am Bigdesk maintainer but because getting this info directly from ES is extremely valuable feature. It is one of the reasons why we are using ES in our team.

this is about removing the native library not the stats it's providing. We can in the meanwhile get several of them from other sources. We might not be able to provide a 1 to 1 replacement but a native lib that is basically unmaintained for more than half a decade is not really an option.

@tlrx
Copy link
Member

tlrx commented Jul 8, 2015

I'm closing this one: sigar has been removed in #12010 and the REST APIs have been updated to expose stats & information that can be collected through JMX management beans (see #12043, #12049, #12053). Network Stats has been removed because there's no simple replacement (see #12054).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants