Unify SearchResponse and BroadcastOperationResponse code around shards header #11064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
>enhancement
v2.0.0-beta1
review
:Core/Infra/Transport API
|
this is great!, LGTM |
…ound shards header Different responses hold the shards header, search, count, flush etc. The code was duplicated in two different places, centralized in RestActions. It turns out that only the search response printed out the status field before the reason, which was added to all other broadcast responses too. Closes elastic#11064
javanna
force-pushed
the
enhancement/unify_shards_header
branch
from
5955b43
to
ba243e7
Compare
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
May 9, 2015
…ound shards header Different responses hold the shards header, search, count, flush etc. The code was duplicated in two different places, centralized in RestActions. It turns out that only the search response printed out the status field before the reason, which was added to all other broadcast responses too. Closes elastic#11064
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different responses hold the shards header, search, count, flush etc. The code was duplicated in two different places, centralized in RestActions.
It turns out that only the search response printed out the status field before the reason, which was added to all other broadcast responses too.