Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that reading indices is allowed before creating their snapshots #11133

Closed
wants to merge 1 commit into from

Conversation

imotov
Copy link
Contributor

@imotov imotov commented May 13, 2015

Clean up of Snapshot/Restore cluster and index block handling.

@imotov imotov added >enhancement v2.0.0-beta1 :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v1.6.0 labels May 13, 2015
…ng their snapshots

Clean up of Snapshot/Restore cluster and index block handling.

Closes elastic#11133
@imotov
Copy link
Contributor Author

imotov commented May 13, 2015

@tlrx, @javanna I cleaned up blocks for snapshot and restore actions a bit. Could you check if these changes make sense?

@clintongormley clintongormley changed the title Snapshot/Restore: check that reading indices is allowed before creati… Snapshot/Restore: check that reading indices is allowed before creating their snapshots May 15, 2015
@tlrx
Copy link
Member

tlrx commented May 18, 2015

@imotov yes, the changes make sense.

I also find it more clean to have a 403 "blocked by: [FORBIDDEN/4/index closed];" exception rather than a failed snapshot with "reason":"Indices don't have primary shards" when snapshotting a closed index.

LGTM

@imotov imotov closed this in f0c18eb May 26, 2015
@imotov imotov removed the discuss label May 26, 2015
imotov added a commit that referenced this pull request May 26, 2015
…ng their snapshots

Clean up of Snapshot/Restore cluster and index block handling.

Closes #11133
@clintongormley clintongormley changed the title Snapshot/Restore: check that reading indices is allowed before creating their snapshots Check that reading indices is allowed before creating their snapshots Jun 7, 2015
@imotov imotov deleted the fix-snapshot-blocks branch May 1, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement v1.6.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants