Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SearchFactory static class in InternalEngine #11154

Merged
merged 1 commit into from May 15, 2015
Merged

Make SearchFactory static class in InternalEngine #11154

merged 1 commit into from May 15, 2015

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented May 13, 2015

Now that lucene provides a way to identify if the warming reader is
the first initial opened reader we can detach this class from the
enclosing and make it static. This is important since it might access
not fully initialized members of the enclosing class since it's initialized
and used during constructor invocation.

@s1monw
Copy link
Contributor Author

s1monw commented May 13, 2015

@mikemccand @jpountz can you please take a look?

@jpountz
Copy link
Contributor

jpountz commented May 15, 2015

LGTM

1 similar comment
@mikemccand
Copy link
Contributor

LGTM

@s1monw
Make SearchFactory static class in InternalEngine
217fd44 
Now that lucene provides a way to identify if the warming reader is
the first initial opened reader we can detach this class from the
enclosing and make it static. This is important since it might access
not fully initialized members of the enclosing class since it's initialized
and used during constructor invocation.
@s1monw s1monw merged commit 217fd44 into elastic:master May 15, 2015
@s1monw s1monw removed the review label May 15, 2015
@s1monw s1monw deleted the cleanup_searcher_factory branch May 15, 2015 20:02
@clintongormley clintongormley added :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. and removed :Engine :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Distributed/Engine Anything around managing Lucene and the Translog in an open shard. >enhancement v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@s1monw @jpountz @mikemccand @clintongormley