Unify script and template requests across codebase #11164
Conversation
colings86
added
>enhancement
v2.0.0-beta1
WIP
:Analytics/Aggregations
| private static final ScriptParser PARSER = new ScriptParser(); | ||
|
|
||
| private String script; | ||
| private ScriptType type; |
There was a problem hiding this comment.
I'd prefer this to be @Nullable as well... relates to xcontent serialization
There was a problem hiding this comment.
if we do make it nullable @colings86 we have to make sure some value gets provided as part of the canExecuteScript call, where the type is required to decide whether the script can be executed or not.
| @@ -360,12 +360,6 @@ Customized scores can be implemented via a script: | |||
| Scripts can be inline (as in above example), indexed or stored on disk. For details on the options, see <<modules-scripting, script documentation>>. | |||
| Parameters need to be set as follows: | |||
There was a problem hiding this comment.
This line looks to be redundant
| .addRange(date(2, 15), date(3, 15)) | ||
| .addUnboundedFrom(date(3, 15))) | ||
| .execute().actionGet(); | ||
| .script(new Script("doc['dates'].values")).addUnboundedTo(date(2, 15)) |
|
LGTM - I've had to skim through a lot of stuff without review on the assumption that
|
|
@markharwood thanks for the review, I've pushed new commit |
| if (!super.equals(obj)) | ||
| return false; | ||
| if (getClass() != obj.getClass()) | ||
| return false; |
There was a problem hiding this comment.
this getClass() test is not necessary, super.equals already takes care of it
|
This PR is mostly impossible to review due to its size, but I skimmed through the patch and it looks good overall. The main concern is about some exception changes that could trigger serialization errors on clusters that have mixed versions, but that should be easy to fix. Let's not wait to long before pushing, such large pull requests can easily become painful to rebase. |
|
LGTM, I think we just need to rename scriptObject() to script() on UpdateRequest |
This change unifies the way scripts and templates are specified for all instances in the codebase. It builds on the Script class added previously and adds request building and parsing support as well as the ability to transfer script objects between nodes. It also adds a Template class which aims to provide the same functionality for template APIs Closes #11091
colings86
added
:Core/Infra/Scripting
This change unifies the way scripts and templates are specified for all instances in the codebase. It builds on the Script class added previously and adds request building and parsing support as well as the ability to transfer script objects between nodes. It also adds a Template class which aims to provide the same functionality for template APIs.
Note: This PR maintains backwards compatibility with versions 1.5 and before. There will be a separate PR to remove the backwards compatibility in 2.0 once this is merged (this will also include updating the "Breaking changes in 2.0" doc.
Closes #11091
Closes #10810
Closes #10113