Make SCAN faster. #11180
Merged
Make SCAN faster. #11180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
v2.0.0-beta1
review
:Search/Search
| * A filtering query that matches all doc IDs that are not deleted and | ||
| * greater than or equal to the configured doc ID. | ||
| */ | ||
| private static class MinDocQuery extends Query { |
|
I like this approach! Left one minor comment, but other than that LGTM. |
|
@martijnvg I pushed a new commit. |
jpountz
force-pushed
the
enhancement/faster_scan
branch
from
5a80bff
to
e08f508
Compare
|
LGTM |
When scrolling, SCAN previously collected documents until it reached where it had stopped on the previous iteration. This makes pagination slower and slower as you request deep pages. With this change, SCAN now directly jumps to the doc ID where is had previously stopped.
jpountz
force-pushed
the
enhancement/faster_scan
branch
from
e08f508
to
22bba91
Compare
|
wow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scrolling, SCAN previously collected documents until it reached where it
had stopped on the previous iteration. This makes pagination slower and slower
as you request deep pages. With this change, SCAN now directly jumps to the
doc ID where is had previously stopped.