Make FilteredQuery a forbidden API. #11224
Conversation
jpountz
added
v2.0.0-beta1
review
:Search/Search
| nullValue.intValue(), | ||
| nullValue.intValue(), | ||
| true, true)); | ||
| return new ConstantScoreQuery(termQuery(nullValue, null)); |
There was a problem hiding this comment.
How come nullValueFilter (no idea what this method is doing, its name is horrible, are we sure we really need it??????) is CSQ(term()) here for short/float but NRQ for long. Why the inconsistency?
|
Overall looks good. i added one comment for a WTF. |
|
Good catch, this was a left-over on my end, I pushed a new commit. |
|
thanks, looks good to me. i still wonder what these methods are doing. We should investigate in a future PR. If you don't know, then I think thats a good sign we should axe them. |
|
If I read https://www.elastic.co/guide/en/elasticsearch/guide/current/_dealing_with_null_values.html#_missing_filter correctly, the goal of this option is to be able to make a difference between a document that is missing a value and a document that was explicitely provided |
|
Worthless. |
This commit makes FilteredQuery a forbidden API and also removes some more usage of the Filter API. There are some remaining code using filters for parent/child queries but I'm not touching this as they are already being refactored in elastic#6511.
jpountz
force-pushed
the
enhancement/filtered_query_forbidden
branch
from
3820142
to
4131bcb
Compare
…bidden Search: Make FilteredQuery a forbidden API.
clintongormley
changed the title
This commit makes FilteredQuery a forbidden API and also removes some more usage
of the Filter API. There are some remaining code using filters for parent/child
queries but I'm not touching this as they are already being refactored in #6511.