Tests: replacement test for missing elements in the diff-serialized cluster state #11257
Labels
discuss
:Distributed/Distributed
A catch all label for anything in the Distributed Area. If you aren't sure, use this one.
Comments
|
I have plans to remove block compression as part of #11279 which means that at least we should again get the same length of serialized cluster states. So if it gets in maybe it would be easiest to add the assertion back instead of working on other ways to compare cluster states. |
|
@imotov Given recent changes we made to how we perform compression, this assertion should be less of an issue now. Should we just add it back? |
|
Yes, it would be great to add it back! Thanks! |
|
@clintongormley Hmm, I don't think we ever added it back. |
imotov
added a commit
to imotov/elasticsearch
that referenced
this issue
Mar 16, 2016
…state We can add it back now that we improved our compression framework. Closes elastic#11257
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The commit fd1954d invalidated the assumption that if two cluster states are equal they must have the same binary serialized length. As a result our smoke test for cluster state diffs started to fail periodically and was removed by the commit 42ad677. Therefore now we don't really have a test for a partially implemented elements in cluster state. In other words if a cluster state element is added to writeTo() but we forget to add it to equalTo and we don't json serialize it, we might miss this fact in this test. We need to come up with a better way to catch situations like this.
The text was updated successfully, but these errors were encountered: