Cleanup field name handling #11272
Merged
Cleanup field name handling #11272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies some of the uses of names, so that the ambiguous "name" is mostly no longer used (does this include path or not?). sourcePath is also removed as it was not used. Not all the uses of .name() have been cleaned up because Mapper still has this, and ObjectMapper depends on it returning the short name, but I would like to leave finishing that cleanup for a future issue.
rjernst
added
v2.0.0-beta1
:Search/Mapping
|
LGTM. I like how this renaming made it immediately obvious that we were wrongly using the short name instead of full name in some places. |
rjernst
added a commit
that referenced
this pull request
May 21, 2015
Mappings: Cleanup names handling
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies some of the uses of names, so that the ambiguous
"name" is mostly no longer used (does this include path or not?).
sourcePath is also removed as it was not used. Not all the
uses of .name() have been cleaned up because Mapper still has
this, and ObjectMapper depends on it returning the short name,
but I would like to leave finishing that cleanup for a future issue.