Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't truncate TopDocs after rescoring #11342

Merged
merged 1 commit into from May 26, 2015
Merged

Don't truncate TopDocs after rescoring #11342

merged 1 commit into from May 26, 2015

Conversation

mikemccand
Copy link
Contributor

I'm not sure why we had this fragment from #7707 ... it is over-trimming TopDocs such that you get size-from results instead of size, which is wrong when from != 0.

Closes #11277

@mikemccand mikemccand self-assigned this May 26, 2015
@mikemccand mikemccand mentioned this pull request May 26, 2015
Closed
@rjernst
Copy link
Member

rjernst commented May 26, 2015

LGTM

@mikemccand mikemccand merged commit 8958096 into elastic:master May 26, 2015
mikemccand added a commit that referenced this pull request May 26, 2015
@mikemccand
Don't truncate TopDocs after rescoring
4334404 
We were previously over-trimming the TopDocs such that you get
size-from hits instead of size, which is wrong when from != 0.

Closes #11127

Closes #11342
mikemccand added a commit that referenced this pull request May 26, 2015
@mikemccand
Don't truncate TopDocs after rescoring
b9b0904 
We were previously over-trimming the TopDocs such that you get
size-from hits instead of size, which is wrong when from != 0.

Closes #11127

Closes #11342
@mikemccand mikemccand deleted the rescore_from_size branch May 26, 2015 09:13
mikemccand added a commit that referenced this pull request May 26, 2015
@mikemccand
Don't truncate TopDocs after rescoring
a4c835c 
We were previously over-trimming the TopDocs such that you get
size-from hits instead of size, which is wrong when from != 0.

Closes #11127

Closes #11342
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Core/Infra/Core Core issues without another label labels May 26, 2015
@clintongormley clintongormley mentioned this pull request Jul 27, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikemccand mikemccand

Labels
>bug :Search/Search Search-related issues that do not fall into other categories v1.5.3 v1.6.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Searches do not return expected number of hits when using rescoring
3 participants
@mikemccand @rjernst @clintongormley