Don't write recoveryType twice #11347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I wonder if we can catch this kind of thing in our BWC tests.. (unconsumed left over). |
This caused scary warnings in the logs Message not fully read (request) for [157] and action [internal:index/shard/recovery/start_recovery], resetting closes elastic#11335
brwe
force-pushed
the
start-recovery-stream
branch
from
819f15e
to
e3b1621
Compare
|
@bleskes it is not really a backwards compat problem, it was for same versions as well. Would be great to always check that but I have no smart idea how. |
|
yeah looks good. We should probably look at the place that logs the warning message and make it assert that everything is consumed (with some escape root for actions where this is expected - I remember discussing using it as a temporary solution in a mixed version cluster). /cc @spinscale |
brwe
added a commit
that referenced
this pull request
May 26, 2015
recovery: don't write recoveryType twice
clintongormley
changed the title
clintongormley
added
v1.6.0
>non-issue
:Distributed/Recovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused scary warnings in the logs
Message not fully read (request) for [157] and action [internal:index/shard/recovery/start_recovery], resetting.
closes #11335
Must have happened while backporting #11179