Read segment info from latest commit whenever possible #11361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikemccand can you take a look at this? |
| @@ -152,7 +152,7 @@ public SegmentInfos readLastCommittedSegmentsInfo() throws IOException { | |||
| */ | |||
| private static SegmentInfos readSegmentsInfo(IndexCommit commit, Directory directory) throws IOException { | |||
| try { | |||
There was a problem hiding this comment.
Maybe remove Directory directory arg here? Or assert that directory == commit.getDirectory()?
|
LGTM, thanks @dakrone! |
dakrone
force-pushed
the
read-si-from-searcher-commit-on-start
branch
from
41c9a61
to
6646881
Compare
Instead of listing the directory to file the latest segments_N file, we should re-use the generation/filename from the last commit. This allows us to avoid potential race conditions on the filesystem as well as reduce the number of directory listings performed.
|
I don't think I'm going to backport this, the Lucene API is different and I think I will work on an alternative to avoid upgrading Lucene 3.x segments when not needed, which is when the race condition usually occurs. |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 28, 2015
fails In the event that reading from the latest commit fails, we should fall back to reading from the `Store` using the traditional `Directory.listAll()` Related to elastic#11361
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 28, 2015
fails In the event that reading from the latest commit fails, we should fall back to reading from the `Store` using the traditional `Directory.listAll()` Related to elastic#11361
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 28, 2015
fails In the event that reading from the latest commit fails, we should fall back to reading from the `Store` using the traditional `Directory.listAll()` Related to elastic#11361
clintongormley
added
>enhancement
:Distributed/Store
clintongormley
changed the title
clintongormley
added
:Distributed/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of listing the directory to file the latest segments_N file, we
should re-use the generation/filename from the last commit. This allows
us to avoid potential race conditions on the filesystem as well as
reduce the number of directory listings performed.