Consolidate shard level modules without logic into IndexShardModule #11416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| bind(ShardPercolateService.class).asEagerSingleton(); | ||
| bind(ShardTermVectorsService.class).asEagerSingleton(); | ||
| bind(IndexShardSnapshotAndRestoreService.class).asEagerSingleton(); | ||
| bind(ShardSuggestService.class).asEagerSingleton(); |
There was a problem hiding this comment.
just to clarify, this seems to be an additional binding that wasn't there before?
There was a problem hiding this comment.
ahh missed that - I just removed the class :)
We have a lot of module classes that don't contain any actual logic, only declarative bind actions. These classes are unnecessary and can be consolidated into the already existings IndexShardModule
s1monw
force-pushed
the
consolidate_modules
branch
from
9363202
to
5a96947
Compare
| import org.elasticsearch.index.store.IndexStore; | ||
| import org.elasticsearch.index.store.Store; | ||
| import org.elasticsearch.index.store.StoreModule; | ||
| import org.elasticsearch.index.suggest.SuggestShardModule; | ||
| import org.elasticsearch.index.termvectors.ShardTermVectorsModule; | ||
| import org.elasticsearch.index.suggest.stats.ShardSuggestService; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of module classes that don't contain any actual logic,
only declarative bind actions. These classes are unnecessary and can
be consolidated into the already existings IndexShardModule