Refactor core index/query time properties into FieldType #11422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mappers are currently used at both index and query time for deciding how to "use" a field. For elastic#8871, we need the index wide view of mappings to have a unified set of settings for each field of a given name within the index. This change moves all the current settings (and methods defining query time behavior) into subclasses of FieldType. In a future PR, this will allow storing the field type at the index level, instead of mappers (which can still have settings that differ per document type). The change is quite large (I'm sorry). I could not see a way to migrate to this in a more piecemeal way. I did leave out cutting over callers of the query methods to using the field type, as that can be done in a follow up.
rjernst
added
v2.0.0-beta1
:Search/Mapping
|
I should clarify, this moves all settings that affects query time behavior. So if something affects only indexing (eg coerce setting for numeric fields), it is left in the mapper. |
|
LGTM I like where this is going |
| /** | ||
| * This defines the core properties and functions to operate on a field. | ||
| */ | ||
| public class MappedFieldType extends FieldType { |
There was a problem hiding this comment.
should this class somehow validate if all required members are set when it's frozen. IE we need analyzer and names to work no?
|
it's a pretty big change and hard to review but I second @jpountz here this looks good and goes into the right direction. I left some minor comments regarding tests and assertions... otehr than that LGTM |
rjernst
added a commit
that referenced
this pull request
Jun 3, 2015
Mappings: Refactor core index/query time properties into FieldType
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mappers are currently used at both index and query time for deciding
how to "use" a field. For #8871, we need the index wide view of
mappings to have a unified set of settings for each field of a given
name within the index.
This change moves all the current settings (and methods defining
query time behavior) into subclasses of FieldType. In a future
PR, this will allow storing the field type at the index level,
instead of mappers (which can still have settings that differ
per document type).
The change is quite large (I'm sorry). I could not see a way to
migrate to this in a more piecemeal way. I did leave out cutting
over callers of the query methods to using the field type, as
that can be done in a follow up.