Minimize the usage of guava classes in interfaces, return types, arguments #11501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments Using these classes in interfaces forces downstream users to use shaded APIs. We should minimize the usage of shaded APIs and keep them internal.
|
+1 In addition to guava being certifiably useless, if you mix in shading and bake this stuff into apis, its about as wrong as it gets. Thanks for fixing this! |
|
LGTM too |
| /** | ||
| * Combines multiple iterators into a single iterator. | ||
| */ | ||
| public static <T> Iterator<T> concat(Iterator<? extends T>... iterators) { |
There was a problem hiding this comment.
long story - related to plugins...
There was a problem hiding this comment.
this method is used in plugins a lot so I just wrap it here
There was a problem hiding this comment.
Because you don't want them to use the shaded Guava because its an implementation detail?
There was a problem hiding this comment.
yeah it's related to #11488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using these classes in interfaces forces downstream users to use shaded APIs.
We should minimize the usage of shaded APIs and keep them internal.