Move null value handling into MappedFieldType #11544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for exists queries to use the null value for a field, null value needs to be part of the field type (should differ between document types). This change moves null value into the field type, as well as simplifies the null value methods available to remove supportsNullValue().
rjernst
added
v2.0.0-beta1
:Search/Mapping
|
|
||
| public String nullValueAsString() { | ||
| return nullValueAsString; | ||
| } |
There was a problem hiding this comment.
Can you add minimal javadocs to these methods?
|
LGTM |
rjernst
added a commit
that referenced
this pull request
Jun 9, 2015
Mapping: Move null value handling into MappedFieldType
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for exists queries to use the null value for
a field, null value needs to be part of the field type (should
differ between document types). This change moves null value
into the field type, as well as simplifies the null value
methods available to remove supportsNullValue().