Cleanup MergeScheduler infrastrucutre #11602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static final String MAX_THREAD_COUNT = "index.merge.scheduler.max_thread_count"; | ||
| public static final String MAX_MERGE_COUNT = "index.merge.scheduler.max_merge_count"; | ||
| public static final String AUTO_THROTTLE = "index.merge.scheduler.auto_throttle"; | ||
| public static final String NOTIFY_ON_MERGE_FAILURE = "index.merge.scheduler.notify_on_failure"; // why would we not wanna do this? |
There was a problem hiding this comment.
+1 to remove this and always notify!
There was a problem hiding this comment.
I will open a new issue for this
|
LGTM, this is a great cleanup ... I just left a few comments. |
|
pushed a new commit |
|
LGTM |
s1monw
force-pushed
the
cleanup_merge_scheduler
branch
from
271715e
to
440580d
Compare
This commit cleans up all the MergeScheduler infrastructure and simplifies / removes all unneeded abstractions. The MergeScheduler itself is now private to the Engine and all abstractions like Providers that had support for multiple merge schedulers etc. are removed. Closes elastic#11602
clintongormley
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans up all the MergeScheduler infrastructure
and simplifies / removes all unneeded abstractions. The MergeScheduler
itself is now private to the Engine and all abstractions like Providers
that had support for multiple merge schedulers etc. are removed.
@mikemccand do you wanna review this please