Use task's class name if not a TimedPrioritizeRunnable #11610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an enhancement, but I'd like to treat it as a bug and backport this as far as possible. Without it, debugging large queue lengths of unknown tasks is very difficult. |
| @@ -318,7 +318,7 @@ public void run() { | |||
| timeInQueue = runnable.timeSinceCreatedInMillis(); | |||
| } else { | |||
| assert false : "expected TimedPrioritizedRunnable got " + task.getClass(); | |||
| source = "unknown"; | |||
| source = "unknown: " + task.getClass(); | |||
There was a problem hiding this comment.
how about "unknown [" + task.getClass() + "]" ?
|
LGTM. Left one minor suggestion |
|
+1 |
This is helpful to track down the origin of pending_tasks that aren't expected. In tests we catch this with an assert, but in production asserts may not be enabled so we should at least add the class name.
dakrone
force-pushed
the
pending-task-classname
branch
from
aaeebe9
to
483a15a
Compare
clintongormley
added
:Core/Infra/Logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful to track down the origin of pending_tasks that aren't
expected. In tests we catch this with an assert, but in production
asserts may not be enabled so we should at least add the class name.