Use System.nanoTime for ThreadPool's estimated time, since it's less likely to go backwards #11626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…likely to go backwards
mikemccand
added
>enhancement
v2.0.0-beta1
:Core/Infra/Core
|
LGTM |
mikemccand
pushed a commit
that referenced
this pull request
Jun 12, 2015
Use System.nanoTime for ThreadPool's estimated time, since it's less likely to go backwards
|
does this mean we should add System.currentTimeMillis() to the fobidden APIs? |
|
@bleskes I guess that would make sense... lets see if it's possible though |
+1 We talked about this in #11058 but there are a number of public APIs that expose their System.currentTimeMillis and it wasn't clear if we could change them ... i.e. whether the caller somehow expected to be able to compare results returned from those APIs with their own calls to System.currentTimeMillis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.