Add support for query boost to SimpleQueryStringBuilder. #11696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,6 +61,13 @@ public void testSimpleQueryString() throws ExecutionException, InterruptedExcept | |||
| assertSearchHits(searchResponse, "1", "2", "3"); | |||
|
|
|||
| searchResponse = client().prepareSearch().setQuery( | |||
| boolQuery() | |||
| .should(simpleQueryStringQuery("foo").boost(-10.0f)) | |||
There was a problem hiding this comment.
Small suggestion: maybe add some explanation or another test case that shows why its the negative boost that makes the difference in the first hit result. Makes reading the test a little easier.
|
LGTM besides the small suggestion on explaining the test case a bit more. |
| @@ -38,6 +39,7 @@ | |||
| private String queryName; | |||
| private String minimumShouldMatch; | |||
| private int flags = -1; | |||
| private float boost = 1.0f; | |||
There was a problem hiding this comment.
I think we use -1 as default in master for all of the other queries, and we move to 1.0f in the query-refactoring branch. Should we use -1 here too for now?
added 2 commits
June 17, 2015 10:49
As per discussion in elastic#11274 this adds support for query boosting to the SimpleQueryStringQuery.
MaineC
force-pushed
the
feature/simple-query-string-addboost
branch
from
e8f28f7
to
5e9106a
Compare
|
Updated and ready for another round. |
|
LGTM |
MaineC
pushed a commit
that referenced
this pull request
Jun 18, 2015
…boost Add support for query boost to SimpleQueryStringBuilder. Relates to #10217
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #11274 this adds support for query boosting to the SimpleQueryStringQuery.
In the process of refactoring SimpleQueryStringQueryBuilder/-Parser we noticed that this is one of the few queries that doesn't support query level boosting, although it in theory it could. Adding this support here.
@dakrone @javanna @cbuescher can either of you check the PR please?