Reclaim memory from fielddata synchronously when an explicit clear is performed. #11697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… performed. The cache we are using for fielddata reclaims memory lazily/asynchronously. While this helps with throughput this is an issue when a clear operation is issued manually since memory is not reclaimed immediately. Since our clear methods already perform in linear time anyway, this commit changes the fielddata cache to reclaim memory synchronously when a clear command is issued manually. However, it remains lazy in case cache entries are invalidated because segments or readers are closed, which is important since such events happen all the time. Close elastic#11695
|
LGTM |
jpountz
added a commit
that referenced
this pull request
Jun 16, 2015
Reclaim memory from fielddata synchronously when an explicit clear is performed.
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache we are using for fielddata reclaims memory lazily/asynchronously. While this
helps with throughput this is an issue when a clear operation is issued manually since
memory is not reclaimed immediately. Since our clear methods already perform in linear
time anyway, this commit changes the fielddata cache to reclaim memory synchronously
when a clear command is issued manually. However, it remains lazy in case cache entries
are invalidated because segments or readers are closed, which is important since such
events happen all the time.
Close #11695