Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load term statistics if required #11737

Merged
merged 1 commit into from Jul 8, 2015
Merged

Only load term statistics if required #11737

merged 1 commit into from Jul 8, 2015

Conversation

wewebber
Copy link
Contributor

Current code loads term statistics even if not requested. This slows down term vector requests markedly (typical figures for stored term vectors on 3k-character field on 4-core machine: 2ms per vector with current code; 0.3ms with this fix).

@s1monw
Copy link
Contributor

s1monw commented Jun 22, 2015

can you sign the CLA so we can pull this in?

@s1monw s1monw self-assigned this Jun 22, 2015
@wewebber
Copy link
Contributor Author

Done, under github account "wewebber". Do you want me to make an equivalent pull request for the master branch (same issue, same fix), or will you apply the fix yourself?

@clintongormley
Copy link

thanks @wewebber - don't worry, we'll handle applying to other branches

jpountz added a commit that referenced this pull request Jul 8, 2015
Only load term statistics if required
@jpountz jpountz merged commit b57ad92 into elastic:1.6 Jul 8, 2015
@kevinkluge kevinkluge removed the review label Jul 8, 2015
@jpountz
Copy link
Contributor

jpountz commented Jul 8, 2015

Merged, thanks!

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
Only load term statistics if required
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Term Vectors labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories v1.6.1 v1.7.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants