New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message not fully read warnings in logs on master #11748
Labels
Comments
I tried disabling bulk compression but i still see it. Maybe i dont disable it correctly though. |
I did this to be sure: diff --git a/core/src/main/java/org/elasticsearch/action/bulk/BulkAction.java b/core/src/main/java/org/elasticsearch/action/bulk/BulkAction.java
index 42d0c22..3554516 100644
--- a/core/src/main/java/org/elasticsearch/action/bulk/BulkAction.java
+++ b/core/src/main/java/org/elasticsearch/action/bulk/BulkAction.java
@@ -49,7 +49,7 @@ public class BulkAction extends Action<BulkRequest, BulkResponse, BulkRequestBui
public TransportRequestOptions transportOptions(Settings settings) {
return TransportRequestOptions.options()
.withType(TransportRequestOptions.Type.BULK)
- .withCompress(settings.getAsBoolean("action.bulk.compress", true)
+ .withCompress(settings.getAsBoolean("action.bulk.compress", false)
);
}
} |
I'll try your patch and see. |
also i am confused, if this is a serious thing, why does it simply get logged and not fail tests and so on? |
Yeah, disabling the bulk compress works here too. I had fat finger'ed the option. |
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this issue
Jun 18, 2015
When using compression over the network, you might sometimes see warnings that the stream was not fully read. This is because DeflaterOutputStream adds an end-of-stream marker. When deserializing, we need to poll for one byte using InputStream.read() to make sure to decode this EOS marker. For the record, it does not strike all the time today because we perform buffering when decompressing to avoid performing too many JNI calls, but it is easy to make this warning happen all the time by decreasing the size of the buffer we use. Close elastic#11748
szroland
pushed a commit
to szroland/elasticsearch
that referenced
this issue
Jun 30, 2015
When using compression over the network, you might sometimes see warnings that the stream was not fully read. This is because DeflaterOutputStream adds an end-of-stream marker. When deserializing, we need to poll for one byte using InputStream.read() to make sure to decode this EOS marker. For the record, it does not strike all the time today because we perform buffering when decompressing to avoid performing too many JNI calls, but it is easy to make this warning happen all the time by decreasing the size of the buffer we use. Close elastic#11748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
when I run
TermsAggregationSearchBenchmark
I get warnings like this:if I disable compression for bulk they go away so I suspect it's something related to message compression that does some kind of padding or so?
if disable bulk compression it goes away
"action.bulk.compress", false
the funny part is that thereaderIndex [114711]
is always the same when I get the message whileexpected [114717];
varies +- 5the message is in
org.elasticsearch.transport.netty.MessageChannelHandler#118
The text was updated successfully, but these errors were encountered: