Extract all shard-level snapshot operation into dedicated SnapshotShardsService #11756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
added
v2.0.0-beta1
review
:Distributed/Snapshot/Restore
| */ | ||
| public static boolean completed(Collection<ShardSnapshotStatus> shards) { | ||
| for (ShardSnapshotStatus status : shards) { | ||
| if (!status.state().completed()) { |
|
left some style comments LGTM in general |
|
@s1monw I pushed the changes, but I am not 100% sure I what you meant in some of your comments. Could you take another look? |
|
left a tiny comment about naming LGTM - feel free to push |
…rdsService Currently the SnapshotsService is concerned with both maintaining the global snapshot lifecycle on the master node as well as responsible for keeping track of individual shards on the data nodes. This refactoring separates two areas of concerns by moving all shard-level operations into a separate SnapshotShardsService. Closes elastic#11756
imotov
force-pushed
the
extract-snapshotshardsservice
branch
from
d233de4
to
f379a13
Compare
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Jun 26, 2015
…ages in the snapshot process If the abort command is issued very early in shard snapshot lifecycle, it might not cancel this shard. This commit backports the change discovered and fixed as part of elastic#11756 Closes elastic#11839
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…ages in the snapshot process If the abort command is issued very early in shard snapshot lifecycle, it might not cancel this shard. This commit backports the change discovered and fixed as part of elastic#11756 Closes elastic#11839
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
SnapshotsServiceis concerned with both maintaining the global snapshot lifecycle on the master node as well as responsible for keeping track of individual shards on the data nodes. This refactoring separates two areas of concerns by moving all shard-level operations into a separateSnapshotShardsService.