Make sure messages are fully read even in case of EOS markers. #11768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using compression over the network, you might sometimes see warnings that the stream was not fully read. This is because DeflaterOutputStream adds an end-of-stream marker. When deserializing, we need to poll for one byte using InputStream.read() to make sure to decode this EOS marker. For the record, it does not strike all the time today because we perform buffering when decompressing to avoid performing too many JNI calls, but it is easy to make this warning happen all the time by decreasing the size of the buffer we use. Close elastic#11748
jpountz
added
v2.0.0-beta1
review
:Distributed/Network
|
LGTM |
|
LGTM too @kimchy can you take one more look here pls |
|
LGTM |
|
@jpountz can we get this in? |
jpountz
added a commit
that referenced
this pull request
Jun 30, 2015
Make sure messages are fully read even in case of EOS markers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using compression over the network, you might sometimes see warnings that
the stream was not fully read. This is because DeflaterOutputStream adds an
end-of-stream marker. When deserializing, we need to poll for one byte using
InputStream.read() to make sure to decode this EOS marker.
For the record, it does not strike all the time today because we perform
buffering when decompressing to avoid performing too many JNI calls, but it
is easy to make this warning happen all the time by decreasing the size of
the buffer we use.
Close #11748