Use abstract runnable in scheduled ping #11795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
s1monw
added a commit
that referenced
this pull request
Jun 22, 2015
Use abstract runnable in scheduled ping
| if (lifecycle.stoppedOrClosed()) { | ||
| logger.trace("[{}] failed to send ping transport message", t); | ||
| } else { | ||
| logger.warn("[{}] failed to send ping transport message", t); |
There was a problem hiding this comment.
The test failed because of a rejection exception. In that case we are pretty sure we are shutting down. In all other cases shouldn't we re-schedule the ping?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this caused a test failure over the weekend
http://build-us-00.elastic.co/job/es_core_master_small/2232/testReport/junit/junit.framework/TestSuite/org_elasticsearch_transport_netty_NettyScheduledPingTests/