Load percolator queries before shard is marked POST_RECOVERY #11799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
>bug
v2.0.0-beta1
review
:Search/Percolator
|
her is a failure related to this http://build-us-00.elastic.co/job/es_core_master_centos/5330/ |
| } | ||
|
|
||
|
|
||
| private void readAllowed(boolean writeOperation) throws IllegalIndexShardStateException { |
|
Looks good - left one comment. |
s1monw
force-pushed
the
fix_percolator_loading
branch
from
a194d76
to
6e84c85
Compare
|
LGTM |
|
LGTM 2 |
If we mark the shard as being in POST_RECOVERY before the percolator is fully set up we might expose it to the user as fully searchable before all queries are loaded. This can lead to wrong results especially in tests when a shard is concurrently marked as STARTED. This commit also removes unneded abstractions on IndexShard where readoperations should be allowed when the purose is a write.
s1monw
force-pushed
the
fix_percolator_loading
branch
from
6e84c85
to
1f36707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we mark the shard as being in POST_RECOVERY before the percolator
is fully set up we might expose it to the user as fully searchable before
all queries are loaded. This can lead to wrong results especially in tests
when a shard is concurrently marked as STARTED.
This commit also removes unneeded abstractions on IndexShard where readoperations
should be allowed when the purpose is a write.
Closes #10722