Add OS name to _nodes and _cluster/nodes #11807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we currently don't expose this.
This adds the following to the OS section of `_nodes`:
```
"os": {
"name": "Mac OS X",
...
}
```
and the following to the OS section of `_cluster/stats`:
```
"os": {
...
"names": [
{
"name": "Mac OS X",
"count": 1
}
],
...
},
```
bleskes
added
>feature
v2.0.0-beta1
review
:Data Management/Stats
| @@ -339,6 +344,11 @@ public void readFrom(StreamInput in) throws IOException { | |||
| availableProcessors = in.readVInt(); | |||
| availableMemory = in.readLong(); | |||
| int size = in.readVInt(); | |||
| names = new ObjectIntHashMap<>(size); | |||
| for (; size > 0; size--) { | |||
There was a problem hiding this comment.
can we have a simple for loop here starting from 0?
There was a problem hiding this comment.
oh man, you insult the C++'er in me :p . will change.
|
left some comments |
|
@s1monw pushed another commit |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we currently don't expose this.
This adds the following to the OS section of
_nodes:and the following to the OS section of
_cluster/stats: