Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recovery state returns 1970s start/end time. #11870

Closed
masaruh opened this issue Jun 25, 2015 · 0 comments
Closed

recovery state returns 1970s start/end time. #11870

masaruh opened this issue Jun 25, 2015 · 0 comments
Assignees
@masaruh
Labels
>bug :Data Management/Stats Statistics tracking and retrieval APIs v1.6.1 v1.7.0

Comments

@masaruh
Copy link
Contributor

masaruh commented Jun 25, 2015

It occurs only version >= 1.6.0.

GET /_recovery?pretty&human returns something like:

   "index_name": {
      "shards": [
         {
            "id": 0,
            "type": "GATEWAY",
            "stage": "DONE",
            "primary": true,
            "start_time": "1970-01-01T12:05:18.603Z",
            "start_time_in_millis": 43518603,
            "stop_time": "1970-01-01T12:05:18.681Z",
            "stop_time_in_millis": 43518681,
            "total_time": "78ms",
            "total_time_in_millis": 78,

I believe it's because System.nanoTime() is used for wall clock time in RecoveryState like https://github.com/elastic/elasticsearch/blob/v1.6.0/src/main/java/org/elasticsearch/indices/recovery/RecoveryState.java#L405
@masaruh masaruh mentioned this issue Jun 25, 2015
Closed
@clintongormley clintongormley changed the title recovery state returns 70s start/end time. recovery state returns 70ms start/end time. Jun 25, 2015
@clintongormley clintongormley added >bug :Data Management/Stats Statistics tracking and retrieval APIs v1.6.1 :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed :Data Management/Stats Statistics tracking and retrieval APIs :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Jun 25, 2015
masaruh added a commit to masaruh/elasticsearch that referenced this issue Jun 29, 2015
@masaruh
Fix RecoveryState timestamps
4b5c6a0 
Use System.currentTimeMillis() for wall clock time and use System.nanoTime() for delta.
Fixes elastic#11870.
@masaruh masaruh changed the title recovery state returns 70ms start/end time. recovery state returns 70s start/end time. Jun 29, 2015
@masaruh masaruh changed the title recovery state returns 70s start/end time. recovery state returns 1970s start/end time. Jun 29, 2015
szroland pushed a commit to szroland/elasticsearch that referenced this issue Jun 30, 2015
@masaruh @szroland
Fix RecoveryState timestamps
d71f817 
Use System.currentTimeMillis() for wall clock time and use System.nanoTime() for delta.
Fixes elastic#11870.
@pickypg pickypg added the v1.7.0 label Jul 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masaruh masaruh

Labels
>bug :Data Management/Stats Statistics tracking and retrieval APIs v1.6.1 v1.7.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clintongormley @masaruh @pickypg